[FFmpeg-devel] [PATCH] examples/decoding_encoding: clarify operations in the usage message

[Michael Niedermayer]

On Thu, Sep 13, 2012 at 09:16:32PM +0200, Stefano Sabatini wrote:
> On date Thursday 2012-09-13 16:43:00 +0200, Michael Niedermayer encoded:
> > On Thu, Sep 13, 2012 at 10:20:03AM +0200, Stefano Sabatini wrote:
> > > ---
> > >  doc/examples/decoding_encoding.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/doc/examples/decoding_encoding.c b/doc/examples/decoding_encoding.c
> > > index d3d1211..c5c0b8f 100644
> > > --- a/doc/examples/decoding_encoding.c
> > > +++ b/doc/examples/decoding_encoding.c
> > > @@ -608,6 +608,8 @@ int main(int argc, char **argv)
> > >      if (argc < 2) {
> > >          printf("usage: %s output_type\n"
> > >                 "API example program to decode/encode a media stream with libavcodec.\n"
> > > +               "This program generates a synthetic stream and encodes it. The same\n"
> > > +               "stream is then decoded and written to a raw data output\n."
> > >                 "output_type must be choosen between 'h264', 'mp2', 'mpg'\n",
> > >                 argv[0]);
> > 
> > makes no sense to me, "to raw data output" and
> > "output_type must be choosen between 'h264', 'mp2', 'mpg'"
> > dont fit together
> 
> Yes this is not perfectly clear, but we assume that whoever is reading
> that is able to guess that output_type refer to the *encoded* files.
> 
> Test reworded, and patch updated.

much better thanks LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120913/b0b6aa73/attachment.asc>