[FFmpeg-devel] [PATCH]Sanitize VBR setting for libfdk-aac

[Reimar Döffinger]

On 12 Sep 2012, at 23:50, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 12/09/2012 5:33 PM, Carl Eugen Hoyos wrote:
>> This is insane.
> 
> It's a lot more sane than passing through a stupid legacy constant that is related to...
> what is it... MPEG-1/2/4?

H.263

> It has no business here, and only serves to make code
> convoluted, and propagate a cargo culted method of coding from the Bad Old Days (2003?).

Currently it would serve to make the code behave consistent with other encoders and in a reasonably user-friendly way.

> However, rather than argue about it, and try and shoehorn it into this option, I think
> a codec private option would be far more sane. The original author agrees. I can send a
> patch for this.

I guess that is an option, though if every encoder ends up with its own private option for a "quality" setting that is very similar for all I can't say I consider that any better code than that "magic division", and it's a good bit more code on top of it...