[FFmpeg-devel] [PATCH] ffprobe: print start_pts and duration_pts stream information

[Stefano Sabatini]

On date Tuesday 2012-09-11 19:04:29 +0200, Clément Bœsch encoded:
> On Tue, Sep 11, 2012 at 11:01:03AM +0200, Stefano Sabatini wrote:
> > On date Saturday 2012-09-08 17:34:52 +0200, Michael Niedermayer encoded:
> > > On Sat, Sep 08, 2012 at 01:02:25PM +0200, Stefano Sabatini wrote:
> > > > Add start_pts and duration_pts fields. A duration_time field is added for
> > > > overall consistency ("duration" alone does not tell if the duration is a
> > > > time or a timestamp), "duration" is kept for backward compatibility but
> > > > should be considered deprecated.
> > > > ---
> > > >  doc/ffprobe.xsd |    3 +++
> > > >  ffprobe.c       |    6 +++++-
> > > >  2 files changed, 8 insertions(+), 1 deletions(-)
> > > 
> > > good idea ...
> > 
> > Updated, "duration_pts" renamed to "duration_ts" as it makes slightly
> > more sense.
> > 
> > Will apply soon if I read no comments.
> > -- 
> > FFmpeg = Fantastic Faithless Maxi Philosophical Enlightened Guide
> 
> > From 68302f62a774909b25d31c6476442211f2469605 Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefasab at gmail.com>
> > Date: Sat, 8 Sep 2012 13:00:13 +0200
> > Subject: [PATCH] ffprobe: print start_pts and duration_ts stream information
> > 
> > Add start_pts and duration_ts fields. The old "duration" field is kept
> > for backward compatibility, but is deprecated in favor of
> > "duration_time".
> 

> Why duration wouldn't be expressed in time by default? I mean what's the
> purpose? I don't see much point in deprecating something we will likely
> never remove (for various reasons you are aware of) and is now duplicated.

"duration" is used in packet and frame and is expressed in timebase
units (so we have "duration_time" which expresses duration in
seconds), so this one will be an exception.

I'm not really happy about this, but yes backward compatibility should
be favored, but I'd like to be able to remove the inconsistency.

Patch updated.
-- 
FFmpeg = Fierce & Formidable Multipurpose Political Evangelical Gangster
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ffprobe-print-start_pts-and-duration_ts-stream-infor.patch
Type: text/x-diff
Size: 2156 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120911/03eeb271/attachment.bin>