[FFmpeg-devel] [PATCH 3/3 v2] random_seed: Replace a VLA with a normal array

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat Sep 8 14:31:33 CEST 2012


Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
---
 libavutil/random_seed.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c
index e60ace0..d1a1fa6 100644
--- a/libavutil/random_seed.c
+++ b/libavutil/random_seed.c
@@ -27,6 +27,7 @@
 #include <math.h>
 #include <time.h>
 #include <string.h>
+#include "avassert.h"
 #include "timer.h"
 #include "random_seed.h"
 #include "sha.h"
@@ -55,7 +56,7 @@ static int read_random(uint32_t *dst, const char *file)
 
 static uint32_t get_generic_seed(void)
 {
-    uint8_t tmp[av_sha_size];
+    uint8_t tmp[120];
     struct AVSHA *sha = (void*)tmp;
     clock_t last_t  = 0;
     static uint64_t i = 0;
@@ -63,6 +64,8 @@ static uint32_t get_generic_seed(void)
     unsigned char digest[32];
     uint64_t last_i = i;
 
+    av_assert0(sizeof(tmp) >= av_sha_size);
+
     if(TEST){
         memset(buffer, 0, sizeof(buffer));
         last_i = i = 0;
-- 
1.7.9.5



More information about the ffmpeg-devel mailing list