[FFmpeg-devel] [PATCH 1/3] vf_idet: Fix unprotected inline asm

Michael Niedermayer michaelni at gmx.at
Fri Sep 7 18:21:37 CEST 2012


On Fri, Sep 07, 2012 at 10:48:27AM -0400, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavfilter/vf_idet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_idet.c b/libavfilter/vf_idet.c
> index 938f4a0..fdeeb51 100644
> --- a/libavfilter/vf_idet.c
> +++ b/libavfilter/vf_idet.c
> @@ -118,7 +118,7 @@ static void filter(AVFilterContext *ctx)
>              delta          += idet->filter_line(cur-refs,  cur, cur+refs, w);
>          }
>      }
> -#if HAVE_MMX
> +#if HAVE_MMX_INLINE
>      __asm__ volatile("emms \n\t" : : : "memory");
>  #endif

theres no mmx optims in vf_idet yet so this could be removed or it
should be replaced by emms_c()

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120907/11ab8177/attachment.asc>


More information about the ffmpeg-devel mailing list