[FFmpeg-devel] [PATCH] lavc/dvdsubdec: parse the size from the extradata.

Clément Bœsch ubitux at gmail.com
Tue Sep 4 18:45:23 CEST 2012


On Tue, Sep 04, 2012 at 06:23:04PM +0200, Nicolas George wrote:
> Le nonidi 19 fructidor, an CCXX, Clément Bœsch a écrit :
> > ---
> >  libavcodec/dvdsubdec.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> Thanks, I intended to to it at some point. The code looks right.
> 

Feel free to do the other settings as well, such as the custom palette
thing ("custom colors" ..."). About the forced subtitles, it seems handled
differently between the pgs and dvd subs, dunno what could be done at that
point ("forced subs: ...").

I don't intend to do much more on this soon, so feel free to have fun with
that.

> Does this make ffplay scale correctly subtitles converted from the sample of
> trac ticket #1277?
> 

The resulting file of:

    ./ffmpeg -i /tmp/SCodecConversionFailsSample.mkv -c:v copy -c:a copy -c:s dvdsub out.mkv

...does not have any size information in the dvd extradata; it's likely
the pgs decoder didn't set them since the dvdsubenc supports that. So to
answer your question, no the output didn't change.

I'll push this patch soon.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120904/281ad7f4/attachment.asc>


More information about the ffmpeg-devel mailing list