[FFmpeg-devel] [PATCH] Revert

[Carl Eugen Hoyos]

Paul B Mahol <onemda <at> gmail.com> writes:

> >>> > It fails here with:
> >>> > mplayer fate-suite/iv32/cubes.mov -vo gl
> >>>
> >>> Not for me with xv.
> >>
> >> I don't think you can test DR for indeo3 with xv.
> >>
> >>> How it fails?
> >>
> >> Massive image corruption.

I see the following error message on the console:
VO: [gl] 160x120 => 160x120 Planar YVU9
X11 error: BadValue (integer parameter out of range for operation)
and the image is resized to something very, very small (without 
any additional messages), the small window shows blue, 
MPlayer continues until eof without actually decoding any 
frame.

> > I cant reproduce this with gl. Do you use multiple threads?

No, but I just found out it is only reproducible with 
a 32bit binary, not with a 64bit binary.

> > Also I see nothing wrong in decoder that can cause such issue.

Note that in the past, some direct rendering issues were 
only reproducible on some systems, not on others.

> Also the decoder which definitely does not support DR1 is yop

?

> (which MPlayer does not support at all),

??

> another one is bink.

That may be true, but since MPlayer deactivates direct 
rendering for them (that is how I interpret "[VD_FFMPEG] 
DRI failure."), it is less visible (for me).

But imo, please remove DR1 from bink if you know it 
doesn't work.

Carl Eugen