[FFmpeg-devel] frei0r patches

[Stefano Sabatini]

On date Monday 2012-10-29 08:28:26 -0600, Roger Pack encoded:
> >> What problems does it have?  I am in touch with them I could forward
> >> one the message :)
> >
> > http://frei0r.dyne.org/codedoc/html/
> >
> > doesn't mention API 1.2 (especially the plugin part).
> >
> > By clicking on "frei0r functions" or on "frei0r header" you get:
> > The requested URL ... was not found on this server.
> 
> Ok it may be fixed now.
> 
> >
> >> > So the question is, how ":"/";" makes any difference?
> >>
> >> basically, since FREI0R_PATH
> >>
> >> looks like this
> >>
> >> /home/foo/frei0r-plugins:/usr/lib/frei0r-1:/etc/frei0r
> >> with the current code, ex looking for the "blur" filter, it searches
> >> for a file named
> >> /home/foo/frei0r-pluginsblur.so
> >>
> >> or its equivalent in windows.  So that's what patch 2 tries to fix.
> >
> >
> >> Also, in windows, FREI0R_PATH might contain full paths, like C:\some\where
> >>
> >> so, basically, you can't use a delimiter of a colon, as it conflicts
> >> with the drive letter.  So you must use something else (java uses a
> >> ';' in windows, the windows PATH environment variable uses a ';' so I
> >> assume it's a standard, though the linked to file only mentions rules
> >> for linux, so it's not explicitly stated anywhere).
> >
> > OK, but I think the better place where to fix this should be first the
> > frei0r spec, then I don't mind if you want to apply the patch now.
> 
> Ok I talked to the frei0r people and they updated the spec to be ';'
> for windows.
> Recommend applying the first patch.

Applied, with a few changes.

> >> The "load_file" method was already truncating at 1024, so I assumed it
> >> was expected.  Maybe they could both be fixed in a separate
> >> commit...or I could do it now if you prefer.
> >
> > OK, but let's try to fix it properly then.
> 
> OK.  Will get around to it eventually, unless somebody beats me to it.
> -roger-

Please check/test the attached patches.

Also I wonder if the trailing "slash" should not rather be a
back-slash on Windows.
-- 
FFmpeg = Foolish and Formidable Majestic Proud Evil Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-frei0r-correctly-handle-paths-longer-than-1023.patch
Type: text/x-diff
Size: 1082 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121029/587b6021/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavfi-frei0r-add-additional-trailing-whitespaces-in-.patch
Type: text/x-diff
Size: 1404 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121029/587b6021/attachment-0001.bin>