[FFmpeg-devel] [PATCH 2/2] fate: add a test for scale with variable input format.

Michael Niedermayer michaelni at gmx.at
Fri Oct 26 01:16:26 CEST 2012


On Thu, Oct 25, 2012 at 09:36:18PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  tests/fate/avfilter.mak   |    1 +
>  tests/lavfi-regression.sh |    1 +
>  tests/ref/lavfi/scalenorm |    1 +
>  3 files changed, 3 insertions(+)
>  create mode 100644 tests/ref/lavfi/scalenorm
> 
> 
> This will avoid the feature breaking without anyone noticing.
> 
> Was there not something with crop or pad too?
> 
> 
> diff --git a/tests/fate/avfilter.mak b/tests/fate/avfilter.mak
> index 3b06d08..b931244 100644
> --- a/tests/fate/avfilter.mak
> +++ b/tests/fate/avfilter.mak
> @@ -27,6 +27,7 @@ FATE_LAVFI = fate-lavfi-alphaextract_rgb                                \
>               fate-lavfi-pixfmts_vflip                                   \
>               fate-lavfi-scale200                                        \
>               fate-lavfi-scale500                                        \
> +             fate-lavfi-scalenorm                                       \
>               fate-lavfi-select                                          \
>               fate-lavfi-setdar                                          \
>               fate-lavfi-setsar                                          \
> diff --git a/tests/lavfi-regression.sh b/tests/lavfi-regression.sh
> index a25b54b..d515323 100755
> --- a/tests/lavfi-regression.sh
> +++ b/tests/lavfi-regression.sh
> @@ -132,6 +132,7 @@ do_lavfi_lavd() {
>  
>  do_lavfi_lavd "life"                 "life=s=40x40:r=5:seed=42:mold=64" -t 2
>  do_lavfi_lavd "testsrc"              "testsrc=r=7:n=2:d=10"
> +do_lavfi_lavd "scalenorm"            "testsrc=s=512x384:d=1:r=5,format=yuv420p[a];testsrc=s=160x120:d=1:r=5[b];[a][b]concat=unsafe=1,scale"

make sure scale gets the bitexact flag set otherwise it might
produce different output on some platforms
also maybe a smaller resolution would be faster

otherwise LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121026/a7d5a6cf/attachment.asc>


More information about the ffmpeg-devel mailing list