[FFmpeg-devel] [PATCH] mxfenc: fix essence container count value

[Michael Niedermayer]

On Thu, Oct 25, 2012 at 11:37:59AM +0200, Matthieu Bouron wrote:
> On Thu, Oct 25, 2012 at 11:21 AM, Matthieu Bouron <matthieu.bouron at gmail.com
> > wrote:
> 
> > On Thu, Oct 25, 2012 at 10:25 AM, Tomas Härdin <tomas.hardin at codemill.se>wrote:
> >
> >> On Wed, 2012-10-24 at 17:14 +0200, Matthieu Bouron wrote:
> >> > @@ -1761,9 +1763,10 @@ static int mxf_write_header(AVFormatContext *s)
> >> >          present[sc->index]++;
> >> >      }
> >> >
> >> > -    if (s->oformat == &ff_mxf_d10_muxer) {
> >> > +    if (s->oformat == &ff_mxf_d10_muxer)
> >> >          mxf->essence_container_count = 1;
> >> > -    }
> >> > +    else if (mxf->essence_container_count > 1)
> >> > +        mxf->essence_container_count++;
> >>
> >> Please don't abuse this field. The EC count is the same - you just want
> >> to write a MultipleDescriptor ref in the Preface. I'd much prefer
> >> something like the attached patch.
> >>
> >
> > Your patch looks much nicer.
> > Thanks !
> >
> 
> Also, don't forget to update the fate tests.

fate updated, patch applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121025/4f5b452f/attachment.asc>