[FFmpeg-devel] [PATCH]Do not detect mpegts-in-mov as mov

[Michael Niedermayer]

On Mon, Oct 22, 2012 at 02:36:34PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > On Mon, Oct 22, 2012 at 11:11:53AM +0200, Carl Eugen Hoyos wrote:
> > > Hi!
> > > 
> > > Attached patch fixes ticket #987 for me.
> > 
> > please check for mpegts like its done for mpegps OR remove the mpegps
> > code and adjust the scores if this is possible. But dont mix the 2
> > approuches
> 
> mpeg-ts in mov start with a mdat atom, apart from that there is nothing 
> that reminds me of a mov (no other atom iirc). Both sample files we have 
> are detected by the mpegts probe code with a score of 100 when testing 
> 2048 bytes. But the mov detection is "quicker" although the files cannot 
> be read at all, only an error message is shown on ffmpeg -i input
> 
> mpeg-ps in mov are real mov files with all kinds of atoms describing the 
> files and the mov demuxer was always able to read the files (it just 
> couldn't actually decode them).
> 
> I don't think the same approach can be used for both type of strams.

mdat is the only atom you can depend on in some movs,
fate-suite/iv32/cubes.mov is one example (if you assume its bigger
so its end is unavailable in the probe buffer)

but the mdat atom is quite invalid, its size for example looks quite
impossible. skiping such invalid atoms in building the score is fine
and should i think fix the tciket too


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121022/a5a7ddb5/attachment.asc>