[FFmpeg-devel] [PATCH] Wrong duration in TS container (Ticket #1836)

[Hendrik Leppkes]

On Mon, Oct 22, 2012 at 3:34 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Oct 22, 2012 at 12:46:29PM +0900, Heesuk Jung wrote:
>> Hi Michael,
>>
>> Thanks for reviewing my patch.
>> I have some question about your comment.
>>
>> this makes stream durations and file duration inconsistent
>>  -> Understand and I will try to apply more reasonable solution.
>>
>
>> there is no ic->iformat->name == "mpegps"
>>  -> Could you explain more detailed background about your comment ?
>
> we use "mpeg" as identifier for mpeg-ps, this maybe should be changed
> as its not a very good idea in the long term. But thats how it was
> named when it was written.
>
>
>>      I believe that estimate_timings_from_pts function is designed for
>> MPEG-PS.
>>      Because remark of estimate_timings_from_pts function is "only usable
>> for MPEG-PS streams"
>>      Also I sometimes find that pts information of TS container is invalid
>> value.
>>     (I guess that this problem is caused by broadcasting recording.)
>
> If the code doesnt work for mpeg-ts its of course ok to disable it for
> this case.

In my experience it seems to usually work OK for mpeg-ts files. There
may be some files where it fails, but disabling it for all files
because of those seems wrong.