[FFmpeg-devel] [PATCH 1/3] lavf/srtdec: simplify start/end computation.

[Clément Bœsch]

On Sun, Oct 21, 2012 at 10:47:56AM +0200, Nicolas George wrote:
> You replied in private again. There may be something wrong in your settings
> that makes you do that frequently.
> 
> Le decadi 30 vendémiaire, an CCXXI, Clément Bœsch a écrit :
> > I thought the long long type was guaranteed to be at least 64 bits by the
> > c99 standard…
> 
> It can not be smaller, but it can be larger, and possibly less efficient.
> 
> > > hh1 * (int64_t)3600 + ...
> > looks ugly :(
> 
> I find the LL ugly too. This is a matter of taste. Of course, in the end, it
> is your patch, you decide.
> 
> > Also we use the LL in various places for that purpose.
> 
> I would have complained if I had spotted them at the time.
> 

Since that's the common way we have at the moment for such matter (see git
grep '[0-9]LL'), I'll keep that syntax.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121021/26a9fab2/attachment.asc>