[FFmpeg-devel] [PATCH] lavc: add text subtitles decoder.

[Clément Bœsch]

On Wed, Oct 17, 2012 at 07:15:22PM +0200, Nicolas George wrote:
> Beware, twice today you replied to me personally instead of to the list.
> 
> Le quartidi 24 vendémiaire, an CCXXI, Clément Bœsch a écrit :
> > I was going to change it but I'm actually not really fond of that
> > suggestion; it sounds to me like it might be OK to have some ass markup
> > and "keep it in its current state", while the escape ass things being
> > default is like "hey we're fixing your crap, but you can ignore it".
> > 
> > Basically, I prefer the user to explicitly disable the stuff we do to
> > clean their mess, than making them think they are fixing our supposedly
> > wrong behaviour with an option.
> 
> We agree that the default behaviour should be the correct one. But
> additionally, I consider that "0" is a more default value than "1", or, in
> other words, that users should be requested to say "do this wrong thing"
> instead of "do not do this right thing".
> 
> Also, it should be a global option, not a per-codec implementation.
> Hopefully, it will be when the design will be cleaned up.
> 

OK OK, if you insist :)

Option renamed.

[...]
> > Oh and by the way, we must be careful if we do that: at the moment, it
> > zero-ends the buffer properly: AFAIK, using av_bprint_chars() doesn't make
> > sure the text buffer is null terminated, so if we remove that av_bprintf
> > from the decoders, we need to replace it with something like
> > av_bprint_chars(buf, '\0', 1), or maybe av_bprintf(buf, "") in case we are
> > doing some av_bprint_chars() calls in the loop. Note that this issue might
> > exists in some other places…
> 
> I believe you read the code wrong: bprint always 0-terminates its buffer
> (unless there is no buffer at all). This is done in av_bprint_grow().
> 

Mmh I may have been confused with special cases using memcpy and the len
instead of a strcpy...

> > So much work to do on the subtitles… Any help would be welcome :)
> 
> I intend to.
> 
> 
> > From 230de618f3444f991569756ffa4f760b42d22d40 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> > Date: Sun, 14 Oct 2012 03:08:30 +0200
> > Subject: [PATCH] lavc: add text subtitles decoder.
> 
> No other remarks on the code.
> 

Tested a bit more, fixed various derp, and applied. Thanks!

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121018/1076fd6b/attachment.asc>