[FFmpeg-devel] [PATCH] lavfi/avf_concat: fix invalid exclusive test.

Nicolas George nicolas.george at normalesup.org
Wed Oct 17 20:00:59 CEST 2012


The invalid test did not cause any actual problem since
the first branch is only possible with bogus filters.

Fix coverity issue CID 733850.

Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
---
 libavfilter/avf_concat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


This one is trivial, I'll push very soon.


diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c
index c0bd621..b3aed3c 100644
--- a/libavfilter/avf_concat.c
+++ b/libavfilter/avf_concat.c
@@ -195,7 +195,7 @@ static void process_frame(AVFilterLink *inlink, AVFilterBufferRef *buf)
         av_log(ctx, AV_LOG_ERROR, "Frame after EOF on input %s\n",
                ctx->input_pads[in_no].name);
         avfilter_unref_buffer(buf);
-    } if (in_no >= cat->cur_idx + ctx->nb_outputs) {
+    } else if (in_no >= cat->cur_idx + ctx->nb_outputs) {
         ff_bufqueue_add(ctx, &cat->in[in_no].queue, buf);
     } else {
         push_frame(ctx, in_no, buf);
-- 
1.7.10.4



More information about the ffmpeg-devel mailing list