[FFmpeg-devel] [PATCH 1/2] mips: Add dependencies on HAVE_INLINE_ASM

[Michael Niedermayer]

On Tue, Oct 16, 2012 at 04:26:30PM +0200, Nedeljko Babic wrote:
> Add dependencies on HAVE_INLINE_ASM for files and parts of code
>  where it is necessary.
> 
> Signed-off-by: Nedeljko Babic <nbabic at mips.com>
> ---
>  libavcodec/mips/Makefile        |   12 ++++--------
>  libavcodec/mips/amrwbdec_mips.c |    2 ++
>  libavcodec/mips/fft_mips.c      |    4 ++--
>  libavcodec/mpegaudiodec.c       |    8 ++++----
>  4 files changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/libavcodec/mips/Makefile b/libavcodec/mips/Makefile
> index 8f64f82..fa75670 100644
> --- a/libavcodec/mips/Makefile
> +++ b/libavcodec/mips/Makefile
> @@ -3,18 +3,14 @@ MMI-OBJS += mips/dsputil_mmi.o                                          \
>  
>  MMI-OBJS-$(CONFIG_MPEGVIDEO)            += mips/mpegvideo_mmi.o
>  
> -MIPSFPU-OBJS-$(CONFIG_AMRNB_DECODER)      += mips/acelp_filters_mips.o     \
> +MIPSFPU-OBJS-$(HAVE_INLINE_ASM)           += mips/acelp_filters_mips.o     \
>                                               mips/celp_filters_mips.o      \
>                                               mips/celp_math_mips.o         \

this would cause the files to be compiled even if no decoder uses them
making things dependant on A && B should be easily possible with a
intermediate variable in the Makefile. But maybe iam missing something
why this isnt appropriate here ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121016/8011cb45/attachment.asc>