[FFmpeg-devel] [PATCH 2/4] lavd: make lavfi device export the metadata up to the AVFrame.

[Clément Bœsch]

On Sun, Oct 14, 2012 at 08:58:18PM +0200, Michael Niedermayer wrote:
> On Sun, Oct 14, 2012 at 02:38:02PM +0200, Clément Bœsch wrote:
> > On Sun, Oct 14, 2012 at 01:14:07PM +0200, Stefano Sabatini wrote:
> > > On date Saturday 2012-10-13 16:36:55 +0200, Clément Bœsch encoded:
> > > > On Thu, Oct 11, 2012 at 11:22:53PM +0200, Clément Bœsch wrote:
> > > > > On Wed, Oct 10, 2012 at 12:55:11AM +0200, Clément Bœsch wrote:
> [...]
> > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > > > index 3c3dad3..9370a56 100644
> > > > --- a/libavcodec/avcodec.h
> > > > +++ b/libavcodec/avcodec.h
> > > > @@ -941,6 +941,12 @@ enum AVPacketSideDataType {
> > > >       * @endcode
> > > >       */
> > > >      AV_PKT_DATA_JP_DUALMONO,
> > > > +
> > > > +    /**
> > > > +     * A list of zero terminated key/value strings. There is no end marker for
> > > > +     * the list, so it is required to rely on the side data size to stop.
> > > > +     */
> > > > +    AV_PKT_DATA_METATAGS,
> > > 
> > > Nit: I don't like METATAGS, "META" means "beyond" (like in
> > > "metaphyisics") or "over" (like in "metamathematics"), meta-tags is
> > > abusing contraction rules resulting in semantical confusion. I
> > > suggest one of these:
> > > AV_PKT_DATA_METADATA_TAGS
> > > AV_PKT_DATA_METADATA
> > > AV_PKT_DATA_TAGS
> > > 
> > > I prefer the longest/more explicit, but I'm OK with the others as
> > > well.
> > > 
> > 
> > I wanted to avoid "datametadata", but if metatags is a problem:
> > AV_PKT_DATA_METADATA, I choose you. Consider it changed locally.
> 
> AV_PKT_METADATA ?
> 

Well, the "DATA" in AV_PKT_DATA seems to refer to the "side data", and
these metadata are also part of these side data...

Also I was wondering about using a FF_ prefix to make sure we don't have
any problem in case of name conflict in the future with the fork. So what
about FF_PKT_DATA_METADATA?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121014/fe6c1100/attachment.asc>