[FFmpeg-devel] [PATCH] lavfi: add kerndeint filter

[Clément Bœsch]

On Sun, Sep 30, 2012 at 11:56:42AM +0200, Stefano Sabatini wrote:
[...]
> > +            srcp = inpic->data[plane];
> > +            dstp = kerndeint->temp_data[plane];
> > +            av_image_copy_plane(dstp, psrc_linesize, srcp, src_linesize, w, h);
> > +        }
> > +    } else {
> > +        for (plane = 0; inpic->data[plane] && plane < 4; plane++) {
> > +            h = plane == PLANAR_Y ? inlink->h : ch;
> > +            w = plane == PLANAR_Y ? inlink->w : cw;
> > +            av_image_copy_plane(outpic->data[plane], outpic->linesize[plane],
> > +                                inpic->data[plane],  inpic->linesize[plane],
> > +                                w, h);
> > +        }
> > +    }
> > +
> > +    return ff_end_frame(inlink->dst->outputs[0]);
> > +}
> 
> It would be useful to add a test for it (checking all the supported
> pixel formats), possibly making use of tinterlace.
> 
> Seems fine otherwise, assuming the output is binary exact with
> mp=kerndeint.

Any news on this patch?

By the way, if adding the test to FATE is a problem, here is a small
summary of the steps I follow when doing it (not sure that's the optimal
way, but it's not intuitive so I'm sharing it):

 - add a do_lavfi entry (or do_lavfi_pixfmts?) test in tests/lavfi-regression.sh
 - touch tests/ref/lavfi/yourfilter. Note that this file is necessary to
   make the test detected (see the next step)
 - Re-run the configure so the test is added to the list (grep yourfilter
   config.mak to check it's indeed found)
 - ``make fate-lavfi-yourfilter | patch -p1'' to update the reference file
 - make fate-lavfi-yourfilter (and make fate) to check if everything is fine
 - Now obviously, make sure the output is correct by modifying the command
   returned by ``make fate-lavfi-yourfilter V=1'' to output a picture
   instead of a md5/crc/whatever
 - now git add lavfi-regression.sh & the ref file and profit!

Cheers,

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121014/3e0a9d41/attachment.asc>