[FFmpeg-devel] [PATCH] lavf/mkv: avoid negative ts by default.

[Clément Bœsch]

On Wed, Oct 10, 2012 at 11:51:52AM -0400, Derek Buitenhuis wrote:
> On 10/10/2012 8:59 AM, Clément Bœsch wrote:
> > From: Clément Bœsch <clement.boesch at smartjog.com>
> > 
> > This fixes playback in some circomstances (like webm in firefox).
> 
> Typo.
> 
> > Regression after 2c34367b.
> > ---
> >  libavformat/matroskaenc.c |    3 +++
> >  tests/ref/lavf/mkv        |    4 ++--
> >  tests/ref/seek/lavf_mkv   |   44 ++++++++++++++++++++++----------------------
> >  3 files changed, 27 insertions(+), 24 deletions(-)
> 
> Shouldn't it be up to the user to set this? I wouldn't really call setting
> a default a "fix"... i.e. why not tell Firefox to fix their code?
> 

I don't know what really is correct...

And the thing is, this is quite a regression: webm output is now
unplayable on the web, at least with Firefox; try for example the file
generated with ./ffmpeg -f lavfi -i 'testsrc[out0]; aevalsrc=0[out1]' -t 5
out.webm.

So yes sure I should make Mozilla fix their code (assuming it's ok to have
negative ts in webm, and that I'm brave enough to try posting on their
bugzilla), but quite a bunch of Firefox won't get updated for a while so I
don't think that's a good idea to keep generating "broken" files by
default.

Another solution is to limit the automatic setting to WebM.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121014/53551fd1/attachment.asc>