[FFmpeg-devel] [PATCH]Fix brokem mp3 in avi
Michael Niedermayer
michaelni at gmx.at
Wed Oct 10 19:46:43 CEST 2012
On Wed, Oct 10, 2012 at 12:46:34PM -0400, Derek Buitenhuis wrote:
> On 10/10/2012 12:36 PM, Carl Eugen Hoyos wrote:
> > - if(st->codec->codec_id == AV_CODEC_ID_AAC && ast->dshow_block_align == 1024 && ast->sample_size == 1024) {
> > + if(st->codec->codec_id == AV_CODEC_ID_AAC && ast->dshow_block_align == 1024 && ast->sample_size == 1024 ||
> > + st->codec->codec_id == AV_CODEC_ID_MP3 && ast->dshow_block_align == 1152 && ast->sample_size == 1152) {
>
> Where do these numbers come from? Is it really just "we have a single sample
They are the frame sizes of the codecs in question
> that we dumped this from"? Unless it's a commonly occuring thing with an
> explanation, I don't think it is a good idea to add hacks in to compensate
> for one broken file.
We have a mp3 in avi and a aac in avi with the bug reporter
indicating that its not the only such file.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121010/b68da4ce/attachment.asc>
More information about the ffmpeg-devel
mailing list