[FFmpeg-devel] [PATCH 4/4] targa: cosmetics - add some whitespace

[Bobby Bingham]

On Mon, Oct 08, 2012 at 07:53:44AM +0200, Clément Bœsch wrote:
[...]
> > -    switch(bpp){
> > +    switch(bpp) {
>
> The coding style likes even more spaces (just after the switch).
>

[...]

> > +
> >      if(flags & TGA_TOPTOBOTTOM) {
>
> You're adding a \n but no space after the if
>
> Same a lot below.
>

[...]

> >
> > -    if(colors){
> > +    if(colors) {
>
> why an incomplete change here
>
> >          int pal_size, pal_sample_size;
> >          if((colors + first_clr) > 256){
>
> but not here?
>

[...]

> > -        for(y = 0; y < h; y++){
> > +        for(y = 0; y < h; y++) {
> >              void *line = &p->data[0][y * p->linesize[0]];
> > -            for(x = 0; x < w >> 1; x++){
> > -                switch(bpp){
> > +            for(x = 0; x < w >> 1; x++) {
> > +                switch(bpp) {
>
> Missing more spaces
>

[...]

> > -static av_cold int targa_end(AVCodecContext *avctx){
> > +static av_cold int targa_end(AVCodecContext *avctx) {
>
> We generally put a \n instead in case of function
>

Pushed a version with these changes. Flame me if I missed anything.

--
Bobby Bingham
このメールは再利用されたバイトでできている。