[FFmpeg-devel] [PATCH] rename time.h to avtime.h

[Reimar Döffinger]

Stefano Sabatini <stefasab at gmail.com> wrote:

>On date Sunday 2012-10-07 14:40:09 +0200, Reimar Döffinger encoded:
>> Nicolas George <nicolas.george at normalesup.org> wrote:
>[...] 
>> >The second issue should be reported to the Android project
>developers.
>> >I am
>> >not opposed to adding workarounds for foreign bugs, but before that,
>I
>> >would
>> >like to see genuine efforts to fix the bug in the correct place, as
>it
>> >would
>> >require less maintenance for ffmpeg and fix things for other
>projects
>> >too.
>> >When the Android developers have stated that, against all evidence,
>> >they are
>> >doing The Right Thing and What Users Expect and closed the bug as
>> >"wontfix",
>> >that is another story.
>> >
>> >On the technical side, leaving "time.h" there with just "#include
>> >"avtile.h""
>> >in it may fix the API stability issue.
>> 
>
>> I think we can in principle rename it in git and just install it
>> under both names to avoid an API issue for most.
>
>Does it fix the problem if we have both? When the Android build
>includes time.h (supposing the libc standard lib header), it may still
>include the libavutil/time.h in libavutil, since it may give priority
>to the one in libavutil.

That depends on the exact setup, but the problem in principle is when building FFmpeg itself with the Android build system, because it adds all source directories to the include path.
This should not be an issue when compiling against a prebuilt FFmpeg, since there will be no source files in the FFmpeg header directories.

>the first place), but again having libavutil/time.h should not be a
>problem with a sane build system.

I personally wouldn't count the Android-obfuscation-system-to-rival-autotools as such.