[FFmpeg-devel] [PATCH] rename time.h to avtime.h

[Michael Niedermayer]

On Sun, Oct 07, 2012 at 11:12:20AM +0200, Nicolas George wrote:
> Le quintidi 15 vendémiaire, an CCXXI, Michael Niedermayer a écrit :
> > never include either except form libavutil, theres no need
> > to include it from outside.
> > 
> > This should fix Ticket1783
> > 
> > The problem was introduced by: ae0a301668da542eaf8855e5dd61d0728181b0dd
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  ffmpeg.c                 |    1 -
> >  ffplay.c                 |    1 -
> >  ffserver.c               |    1 -
> >  libavcodec/dct-test.c    |    1 -
> >  libavcodec/fft-test.c    |    1 -
> >  libavcodec/motion-test.c |    1 -
> >  libavdevice/fbdev.c      |    1 -
> >  libavdevice/jack_audio.c |    1 -
> >  libavdevice/oss_audio.c  |    1 -
> >  libavdevice/x11grab.c    |    1 -
> >  libavformat/avformat.h   |    1 -
> >  libavformat/avio.c       |    1 -
> >  libavformat/hls.c        |    1 -
> >  libavformat/hlsproto.c   |    1 -
> >  libavformat/mux.c        |    1 -
> >  libavformat/rtmphttp.c   |    1 -
> >  libavformat/rtpdec.c     |    1 -
> >  libavformat/rtsp.c       |    1 -
> >  libavformat/rtspdec.c    |    1 -
> >  libavformat/rtspenc.c    |    1 -
> >  libavformat/sapenc.c     |    1 -
> >  libavformat/utils.c      |    1 -
> >  libavutil/avtime.h       |   41 +++++++++++++++++++++++++++++++++++++++++
> >  libavutil/avutil.h       |    1 +
> >  libavutil/des.c          |    1 -
> >  libavutil/time.c         |    2 +-
> >  libavutil/time.h         |   41 -----------------------------------------
> >  tools/aviocat.c          |    1 -
> >  tools/pktdumper.c        |    1 -
> >  29 files changed, 43 insertions(+), 67 deletions(-)
> >  create mode 100644 libavutil/avtime.h
> 
> >  delete mode 100644 libavutil/time.h
> 
> Unless I am mistaken, time.h is an installed header, which means that is a
> break of public API. Also, since you did not change lavu/Makefile, I expect
> "make install" to fail.

yes and yes, i forgot the Makefile

do you have another / better suggestion on how to fix this ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121007/ef374316/attachment.asc>