[FFmpeg-devel] [PATCH]Fix overread in pcx decoder

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Oct 6 16:47:53 CEST 2012


Hi!

Attached patch fixes a crash when reading invalid pcx files, not all 
codepaths tested.

Please review, Carl Eugen
-------------- next part --------------
Index: libavcodec/pcx.c
===================================================================
--- libavcodec/pcx.c	(revision 13078)
+++ libavcodec/pcx.c	(working copy)
@@ -42,7 +42,7 @@
 /**
  * @return advanced src pointer
  */
-static const char *pcx_rle_decode(const uint8_t *src, uint8_t *dst,
+static const unsigned char *pcx_rle_decode(const uint8_t *src, uint8_t *dst,
                             unsigned int bytes_per_scanline) {
     unsigned int i = 0;
     unsigned char run, value;


More information about the ffmpeg-devel mailing list