[FFmpeg-devel] [PATCH] movenc: Force setting of "Samples per packet" field in SoundDescription V1 extended info

[Michael Niedermayer]

On Fri, Oct 05, 2012 at 09:42:52AM +0100, Tim Nicholson wrote:
> Apple spec is for this field to be always one for uncompressed PCM,
> currently this is only forced for V2 Sound descriptions and left at
> track->enc->frame_size for V1.
>

> Curiously this seems to come out at "1" for 'le' flavours anyway but
> 'be' returns "0".

why does the frame_size field differ between le and be ?
that doesnt feel correct at all


[...]
> -        avio_wb32(pb, track->enc->frame_size); /* Samples per packet */
> +        if (mov_pcm_le_gt16(track->enc->codec_id) ||
> +            mov_pcm_be_gt16(track->enc->codec_id))
> +            avio_wb32(pb, 1); /*  must be 1 for  uncompressed formats */
> +        else
> +            avio_wb32(pb, track->enc->frame_size); /* Samples per packet */

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121005/fb87fa46/attachment.asc>