[FFmpeg-devel] [PATCH 1/2] Fix DPX decoder Rewrite the DPX decoder to work with provided sample DPXs

[Michael Niedermayer]

On Thu, Oct 04, 2012 at 11:01:41PM +0200, Georg Lippitsch wrote:
> Am 04.10.2012, 22:34 Uhr, schrieb mashiat.sarker at gmail.com
> <mashiat.sarker at gmail.com>:
> 
> >On 10/04/2012 01:48 PM, Georg Lippitsch wrote:
> >>---
> >>  libavcodec/dpx.c |  157
> >>+++++++++++++++++++++++++++++-------------------------
> >>  1 files changed, 84 insertions(+), 73 deletions(-)
> >
> >Your patch looks like a series of fixes squashed together in one
> >patch. It does not explain what was our decoder doing wrong and
> >how you have fixed that. Just saying that your patch fixes a bunch
> >of sample is not enough.
> 
> Please follow discussion to message
> <1346155638-23632-1-git-send-email-georg.lippitsch at gmx.at>
> (Subject: [PATCH] dpx: fix some stupid typos)
> 
> Holger provided some DPX samples and it turned out that many of them
> didn't open properly.
> 
> 
> >I propose you split your patch into a patchset. From a quick look
> >at your patch, it seemed completely doable to me. Feel free to
> >correct me if I am wrong.
> 
> There seem to be some disagreement on patchsets on this list. When I
> recently submitted some patch sets, people suggested to merge into
> one patch. Could you elaborate on why it should be a patch set this
> time?

i dont remember the case you refer to so i cant comment on that,
but in general

patches should be self contained, that is 1 bugfix = 1 patch,
1 feature = 1 patch
when in doubt its probably better to split, it can help with
git bisect later.


[...]

thanks
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121005/35b52731/attachment.asc>