[FFmpeg-devel] aac encoder patch: allow it to work with 5.1

Michael Niedermayer michaelni at gmx.at
Thu Oct 4 23:31:50 CEST 2012


On Thu, Oct 04, 2012 at 12:52:29PM -0600, Roger Pack wrote:
> After some discussion for this trac ticket:
> https://ffmpeg.org/trac/ffmpeg/ticket/1784
> 
> It appears that the internal aac encoder "as is" is broken with 5.1 audio input.
> With small test files like those uploaded to the ticket, it seems to
> "lose" 3 of the 6 channels, and garble 2 others.
> With larger test files, like sintel.mpg linked to the same, it seems
> to "lose" 3 of the 6 channels.
> 
> As suggested there, adding -aac_coder 0
> seems to fix it and allow it to keep all the channels.
> So, without knowing really what is going on, attached is a patch for
> review to set that as the default, since it appears to work better
> than the current behavior, at least.
> Feedback welcome.
> -roger-

coder 0 garbles simple stereo here, so i dont think fixing this is as
simple as this

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121004/d022ced0/attachment.asc>


More information about the ffmpeg-devel mailing list