[FFmpeg-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

[Clément Bœsch]

On Thu, Oct 04, 2012 at 07:51:18AM -0700, Ronald S. Bultje wrote:
> Hi,
> 
> On Oct 4, 2012 7:16 AM, "Clément Bœsch" <ubitux at gmail.com> wrote:
> >
> > On Thu, Oct 04, 2012 at 04:13:24PM +0200, Clément Bœsch wrote:
> > [...]
> > > > >      if(MB_MBAFF){
> > > > > -        h->ref_count[0] <<= 1;
> > > > > -        h->ref_count[1] <<= 1;
> > > > > +        local_ref_count[0] <<= 1;
> > > > > +        local_ref_count[1] <<= 1;
> > > > >      }
> > > >
> > > > maybe
> > > > local_ref_count[0] = h->ref_count[0] << MB_MBAFF
> > > > is faster but otherwise whatever is fast & clean is fine with me
> > > >
> > >
> > > Ah right, I'll push the attached version tomorrow unless there is an
> > > objection then.
> > >
> >
> > Derp, sent a bad draft version. Fixed.
> 
> Has anyone been able to test if this decreases the amount of fate failures?
> 

It's running since a while without any failure here. We'll be sure in a
week or two with FATE. Helgrind still complains about the state issues I
mentioned in the other mail though.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121004/b56c28f8/attachment.asc>