[FFmpeg-devel] [PATCH] Add support for pcm_*_BE in mov

[Michael Niedermayer]

On Mon, Oct 01, 2012 at 05:25:16PM +0100, Tim Nicholson wrote:
> Currently bit depths >16 are only handled correctly if they are LE.
> This patch adds support for BE variants and fixes ticket #1767
> 
> Note I have not renamed the function in this patch which suggests a test
> for le variants only. Updating this to reflect the general nature of the
> function can be done in a separate cosmetic patch if required.

this patch breaks fate
--- ./tests/ref/fate/acodec-pcm-s24be   2012-09-28 15:10:07.693160421 +0200
+++ tests/data/fate/acodec-pcm-s24be    2012-10-01 21:14:53.655082131 +0200
@@ -1,4 +1,4 @@
-5d843e1f56796aae3185016f164b16b7 *tests/data/fate/acodec-pcm-s24be.mov
-1588269 tests/data/fate/acodec-pcm-s24be.mov
-64151e4bcc2b717aa5a8454d424d6a1f *tests/data/fate/acodec-pcm-s24be.out.wav
-stddev:    0.00 PSNR:999.99 MAXDIFF:    0 bytes:  1058400/  1058400
+a6c17c2779430a58753c53c72428990c *tests/data/fate/acodec-pcm-s24be.mov
+1588323 tests/data/fate/acodec-pcm-s24be.mov
+3a14c1dea40f39a997c6ea32306aeb8b *tests/data/fate/acodec-pcm-s24be.out.wav
+stddev: 7991.53 PSNR: 18.28 MAXDIFF:32768 bytes:  1058400/  1058400
TEST    acodec-adpcm-ima_qt
Test acodec-pcm-s24be failed. Look at tests/data/fate/acodec-pcm-s24be.err for details.
make: *** [fate-acodec-pcm-s24be] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/fate/acodec-pcm-s32be   2012-09-28 15:10:07.693160421 +0200
+++ tests/data/fate/acodec-pcm-s32be    2012-10-01 21:14:53.679082132 +0200
@@ -1,4 +1,4 @@
-b34c66c56df1b1e75688929cf20670b9 *tests/data/fate/acodec-pcm-s32be.mov
-2117473 tests/data/fate/acodec-pcm-s32be.mov
-64151e4bcc2b717aa5a8454d424d6a1f *tests/data/fate/acodec-pcm-s32be.out.wav
-stddev:    0.00 PSNR:999.99 MAXDIFF:    0 bytes:  1058400/  1058400
+7eb1a65795f695b04e7e87b9322df15e *tests/data/fate/acodec-pcm-s32be.mov
+2117527 tests/data/fate/acodec-pcm-s32be.mov
+f89e7e27471fe95304cc5e76ab728932 *tests/data/fate/acodec-pcm-s32be.out.wav
+stddev: 7991.00 PSNR: 18.28 MAXDIFF:32768 bytes:  1058400/  1058400

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121001/ea66a6d1/attachment.asc>