[FFmpeg-devel] [PATCH 2/5] pp: add pp_get_context2().

[Clément Bœsch]

On Sun, Nov 18, 2012 at 12:24:45AM +0100, Michael Niedermayer wrote:
[...]
> > > Is this neccessary ?
> > > wouldnt simply adding a PP_CPU_CAPS_AUTO achive nearly the same ?
> > > 
> > 
> > Sure, but I thought it would be better to get rid at some point of the
> > duplicated flags and pixel formats; that's the main reason of that patch,
> > we can remove all the PP macro and allow a better integration with FFmpeg.
> > 
> > This will also allow a native vf pp to not bother anymore about a pixel
> > formats mapping.
> > 
> > New attached patch clarifies how it would look at next major bump.
> [...]
> 
> > --- a/libpostproc/postprocess.h
> > +++ b/libpostproc/postprocess.h
> > @@ -77,9 +77,11 @@ void  pp_postprocess(const uint8_t * src[3], const int srcStride[3],
> >  pp_mode *pp_get_mode_by_name_and_quality(const char *name, int quality);
> >  void pp_free_mode(pp_mode *mode);
> >  
> > -pp_context *pp_get_context(int width, int height, int flags);
> > +pp_context *pp_get_context2(int width, int height, int pixfmt);
> 
> before this there are general purpose flags allowing future extension
> after this they are not there anymore.
> I dont know if we will ever need such flags but it doesnt seem
> a good idea to me to drop them
> 

If that occurs, won't we instead choose to use AVOptions/av_class (like
every other libs of the projects), which should allow such flexibility? We
should be able to add this without major bumps.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121118/4b78e0e7/attachment.asc>