[FFmpeg-devel] [PATCH 1/4] lavu/bprint: implement av_bprint_strftime().

Nicolas George nicolas.george at normalesup.org
Sat Nov 17 11:52:10 CET 2012


Le quintidi 25 brumaire, an CCXXI, Stefano Sabatini a écrit :
> > +        if (!room)
> > +            room = strlen(fmt) / 2 + 1;
> Is this required? Shouldn't the previous assignment guarantee that
> room is > 0?

I just forgot to remove it. Fixed.

> Nit: @note

Changed.

> missing documentation for fmt (which should mention the function
> strftime()) and tm parameters

I figured it was completely obvious, given the name of the function itself,
but added.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121117/1df7572f/attachment.asc>


More information about the ffmpeg-devel mailing list