[FFmpeg-devel] [PATCH 2/2] swr/rematrix: move templating parameters to template itself.

[Clément Bœsch]

On Thu, Nov 15, 2012 at 04:03:31AM +0100, Michael Niedermayer wrote:
[...]
> > +#if defined(CONFIG_REMATRIX_FLT)
> > +# define ONE (1.0)
> > +# define R(x) x
> > +# define SAMPLE float
> > +# define COEFF float
> > +# define INTER float
> > +# define RENAME(x) x ## _float
> > +#elif defined(CONFIG_REMATRIX_DBL)
> > +# define ONE (1.0)
> > +# define R(x) x
> > +# define SAMPLE double
> > +# define COEFF double
> > +# define INTER double
> > +# define RENAME(x) x ## _double
> > +#elif defined(CONFIG_REMATRIX_S16)
> > +# define ONE (-32768)
> > +# define R(x) (((x) + 16384)>>15)
> > +# define SAMPLE int16_t
> > +# define COEFF int
> > +# define INTER int
> > +# define RENAME(x) x ## _s16
> > +#endif
> 
> these should get 4 spaces for indent
> also CONFIG_* appers here too a bad name otherwise LGTM
> 

Renamed to TEMPLATE_*, added spaces, and pushed.

Thanks,

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121115/d810c39c/attachment.asc>