[FFmpeg-devel] [PATCH 3/7] lavfi/tile: add nb_frames option.

[Alexander Strasser]

Hi,

Clément Bœsch wrote:
> ---
>  libavfilter/vf_tile.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
[...]
> @@ -73,6 +75,15 @@ static av_cold int init(AVFilterContext *ctx, const char *args)
>                 tile->w, tile->h);
>          return AVERROR(EINVAL);
>      }
> +
> +    if (tile->nb_frames == 0) {
> +        tile->nb_frames = tile->w * tile->h;
> +    } else if (tile->nb_frames > tile->w * tile->h) {
> +        av_log(ctx, AV_LOG_ERROR, "nb_frames must be inferior to %dx%d=%d\n",
> +               tile->w, tile->h, tile->w * tile->h);

  I think the message is off-by-one and to me "inferior" sounds unnatural
in this usage; I am not a native English speaker though.

  What about "less than or equal to" here and in the filters.texi doc?

> +        return AVERROR(EINVAL);
> +    }

[...]

  Alexander