[FFmpeg-devel] [PATCH] lavu/opt: show valid range in case of out-of-range value

Stefano Sabatini stefasab at gmail.com
Wed Nov 7 23:23:09 CET 2012


On date Sunday 2012-11-04 15:58:12 +0100, Stefano Sabatini encoded:
> On date Sunday 2012-11-04 15:41:16 +0100, Nicolas George encoded:
> > Le quartidi 14 brumaire, an CCXXI, Stefano Sabatini a écrit :
> > > Improve feedback.
> > 
> > Good idea.
> > 
> > > ---
> > >  libavutil/opt.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/libavutil/opt.c b/libavutil/opt.c
> > > index ab95d04..3122e74 100644
> > > --- a/libavutil/opt.c
> > > +++ b/libavutil/opt.c
> > > @@ -88,8 +88,8 @@ static int read_number(const AVOption *o, void *dst, double *num, int *den, int6
> > >  static int write_number(void *obj, const AVOption *o, void *dst, double num, int den, int64_t intnum)
> > >  {
> > >      if (o->max*den < num*intnum || o->min*den > num*intnum) {
> > > -        av_log(obj, AV_LOG_ERROR, "Value %f for parameter '%s' out of range\n",
> > > -               num*intnum/den, o->name);
> > > +        av_log(obj, AV_LOG_ERROR, "Value %f for parameter '%s' out of range [%f - %f]\n",
> > > +               num*intnum/den, o->name, o->min, o->max);
> > 
> > Does %g not provide a more readable output in the general case?
> 
> Works for me, locally updated.

Pushed.
-- 
FFmpeg = Furious and Faithful Magnificient Power Ephemeral Geek


More information about the ffmpeg-devel mailing list