[FFmpeg-devel] [PATCH] log: color prefixes according to their source.
Michael Niedermayer
michaelni at gmx.at
Mon May 28 12:53:21 CEST 2012
On Mon, May 28, 2012 at 07:56:40AM +0200, Clément Bœsch wrote:
> On Mon, May 28, 2012 at 03:23:51AM +0200, Michael Niedermayer wrote:
> > The use of cyan is droped from the levels to avoid confusion
> > magenta/cyan/blue is used for muxer/codec/filter layer
> >
>
> Ah it's nice!
>
> Unfortunately it doesn't match filter with their own context (which
> happens often).
> Maybe I'd avoid the mix of bold (light) and non-bold
> colors for semantically similar elements: codec/cyan is normal style,
> while muxer/blue is a "light blue" (see attached). It's not a problem with
> the errors, but I think the categories should have a common style (and yes
> I know the "normal" colors are not always readable, and available colors
> limited).
it seems xterm displays bright blue in a more ugly way then rxvt
new patchset posted, that should address the raised issues
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120528/ae6b8fe6/attachment.asc>
More information about the ffmpeg-devel
mailing list