[FFmpeg-devel] [PATCH] ffmpeg: use AVBPrint API for filter args.

[Nicolas George]

Le septidi 7 prairial, an CCXX, Clément Bœsch a écrit :
> > Why the strange values? 1 for automatic size seems saner.
> No particular reason; 256 was the original args size, and 2048 an
> arbitrary up limit: I guess tens of -map_channel can reach it, and OTOH an
> unlimited maximum sounds unreasonable.

Basic sanity check: when I write "automatic", I refer to C's automatic
storage class, i.e. the buffer is entirely on the stack, limited by the
structure of the bprint buffer, slightly less than 1024 in this particular
case.

> Since that scope triggers at least one of the av_bprintf(), it looked like
> the simpler way to do that operation.

It does not look that way at a first glance.

IMHO, a good solution would be to make the option parser accept a final
delimiter (or even empty fields).

> Truncated? What do you mean?

If you put a limit on the size of the buffer and write more, the rest will
be ignored.

> The fork has no af volume, and thus still has the volume hack in. The only
> input filter they auto insert is asyncts, and we do things differently on
> that matter anyway.

Ok.

Regards,

-- 
  Nicolas George