[FFmpeg-devel] [PATCH] Fix warnings about int64toint32conversion

[Don Moir]

----- Original Message ----- 
From: "Michael Bradshaw" <mbradshaw at sorensonmedia.com>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Monday, May 21, 2012 1:40 PM
Subject: Re: [FFmpeg-devel] [PATCH] Fix warnings about 
int64toint32conversion


> On Mon, May 21, 2012 at 11:16 AM, Don Moir <donmoir at comcast.net> wrote:
>> ----- Original Message ----- From: "Michael Bradshaw"
>> <mbradshaw at sorensonmedia.com>
>>
>> To: "FFmpeg development discussions and patches" 
>> <ffmpeg-devel at ffmpeg.org>
>> Sent: Monday, May 21, 2012 12:56 PM
>>
>> Subject: Re: [FFmpeg-devel] [PATCH] Fix warnings about
>> int64toint32conversion
>>
>>
>>> On Wed, May 16, 2012 at 12:05 PM, Michael Bradshaw
>>> <mbradshaw at sorensonmedia.com> wrote:
>>>>
>>>> Wow, this turned into a lively discussion.
>>>>
>>>> To answer some of the questions: these warnings are from MSVC 2008 and
>>>> 2010 (haven't tested other versions). Yes, two of the casts are
>>>> technically unnecessary (read below). I have tested this with gcc
>>>> 4.2.1 with a random sampling of 1000000 integers, and the output is
>>>> the same before and after the patch.
>>>>
>>>> I've attached a new version of the patch that removes the two
>>>> unnecessary casts. I originally added them because a) I have a habit
>>>> of being explicit when demoting data types and b) for consistency. I
>>>> think you have a valid point Reimar that they probably shouldn't be
>>>> included in this patch, though, and MSVC 2008 and 2010 don't complain
>>>> if the two casts are removed.
>>>>
>>>> Let me know if this patch is better.
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>
>>>
>>> Ping.
>>>
>>> Reimar said he has no objections to this newer patch. Does anyone else?
>>
>>
>> Was av_cmp_q in rational.h taken care of ? Don't remember seeing that in
>> proposed patch.
>
> It was not, no. I don't get any warnings from that function in VS 2008
> or 2010, so I didn't modify it.
>
> I just turned my warning level up to W4 and got several more warnings
> in libavutil/common.h (but I still can't get av_cmp_q to give any
> warnings; have you set some compiler flags or something?).

using C++ and warning level W3, I get the warning in av_cmp_q