[FFmpeg-devel] [PATCH 1/3] ffmpeg: fix a crash with complex filters when pix_fmt is not specified

[Michael Niedermayer]

On Fri, May 04, 2012 at 04:10:13PM +0200, Michael Niedermayer wrote:
> On Fri, May 04, 2012 at 03:40:34PM +0200, Matthieu Bouron wrote:
> > On Thu, May 03, 2012 at 04:04:21PM +0200, Nicolas George wrote:
> > > Le quintidi 15 floréal, an CCXX, Matthieu Bouron a écrit :
> > > > My bad, this patch fix a segv for:
> > > >   ffmpeg -i input.mxf -filter_complex "[0:0]fieldorder=tff" output.wav
> > > 
> > > Right, so that is when there is a filter graph but its output is unused. I
> > > confirm the segfault.
> > > 
> > > I suppose that with your patch, it fails with an error message? If so, that
> > > seems fine (but a few more words in the commit message to explain this would
> > > be nice).
> > > 
> > 
> > Patch updated.
> 
> >  ffmpeg.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > b84ea3d0db09d138f21579a617a811c170c360d6  0001-ffmpeg-fix-crash-when-complex-filter-output-is-not-u.patch
> > From 2a91e89a83c5bf31c4c798bd4a1fb1c3dbf2df11 Mon Sep 17 00:00:00 2001
> > From: Matthieu Bouron <matthieu.bouron at smartjog.com>
> > Date: Wed, 2 May 2012 16:11:09 +0200
> > Subject: [PATCH 1/4] ffmpeg: fix crash when complex filter output is not used
> > 
> > ffmpeg -i in.mxf -filter_complex "[0:0]fieldorder=tff" out.wav will
> > fail with an error message instead of crashing.
> 
> LGTM

applied

sorry for the delay, i thought you wanted to setup a public git clone
so i just replied with "LGTM" and thought i could just pull it easily
later from you ... then i forgot about this patch...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120520/d412cdbc/attachment.asc>