[FFmpeg-devel] [PATCHv3] lavf: add av_guess_frame_sample_aspect_ratio function

[Marton Balint]

On Thu, 17 May 2012, Joakim Plate wrote:

>>>
>>> No further comments received, please apply the v3 patch.
>>
>> locally applied, will be in my next push
>>
>
> Damn.. :). Missed updates here.
>
> You have declared function as:
>
> AVRational av_guess_sample_aspect_ratio(AVFormatContext *format,
> AVStream *stream, AVFrame *frame)
>
> This makes it hard to use the function if there is no AVFrame. (ie
> directly after av_find_stream_info).

You can use NULL in that case for AVFrame. The function handles it.

> Secondly i may be blind, but i
> can't see that you use the format pointer at all in the function. Was
> that just for future safety?

Yes, that's right.

Regards,
Marton