[FFmpeg-devel] [PATCH] movenc: Fix muxing of Apple Quicktime chapters.

[Michael Niedermayer]

On Sun, May 13, 2012 at 05:51:27PM -0700, Philip Langdale wrote:
> On Mon, 14 May 2012 09:48:06 +0900
> Yusuke Nakamura <muken.the.vfrmaniac at gmail.com> wrote:
> 
> > 
> > For 3GPP timed text, atom type tag of the sample description is
> > 'tx3g', not 'text'.
> 
> Your statement is correct in isolation, but in the context of Apple's
> chapter format, they use and expect 'text'. This isn't a real subtitle
> track.

The check for extradata to determine if its a subtitle or chapter track
seems fragile. 

otherwise i cant really comment on this as i have no means to test
ATM and also cant comment on undocumented fields

have you tested this with a few different players to make sure it
has no negative sideeffects ?

but in the absence of further comments iam in favor of applying this

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120517/c1642de6/attachment.asc>