[FFmpeg-devel] [PATACH] dv_profile: fix decoding of SoftLab DVCPRO codec (PAL mode)

[Reimar Döffinger]

On Tue, May 15, 2012 at 07:03:59PM +0200, Piotr Bandurski wrote:
> fixes ticket #1307

> diff --git a/libavcodec/dv_profile.c b/libavcodec/dv_profile.c
> index 8359dae..d773df0 100644
> --- a/libavcodec/dv_profile.c
> +++ b/libavcodec/dv_profile.c
> @@ -298,6 +298,9 @@ const DVprofile* avpriv_dv_frame_profile2(AVCodecContext* codec, const DVprofile
>  
>      if(stype == 0 && codec && codec->codec_tag==AV_RL32("dvsd") && codec->coded_width==720 && codec->coded_height==576)
>          return &dv_profiles[1];
> +    
> +    if(stype == 31 && codec && codec->codec_tag==AV_RL32("SL25") && codec->coded_width==720 && codec->coded_height==576)
> +        return &dv_profiles[2];

We already have a special-case returning dv_profiles[2] above that, have
you checked if there might a way to extend that check or such?
While I'm not against it in principle, I'd prefer to get the checks
based on codec_tag and width/height down, since they break completely
after remuxing the files.