[FFmpeg-devel] [PATCH 1/2] configure: produce useful uninstalled pc files.
Clément Bœsch
ubitux at gmail.com
Sun May 13 12:33:49 CEST 2012
On Sun, May 13, 2012 at 09:23:11AM +0200, Nicolas George wrote:
> The old files were scattered in several directories,
> with an unusual name, but dependencies to the usual name,
> and relative paths.
>
> The new files are regrouped in a singled directory
> (doc/examples/pc-uninstalled) with their usual name
> and more absolute paths.
>
> With this change, it becomes possible to compile the examples
> with the ffmpeg build tree by setting the environment variable:
> PKG_CONFIG_PATH=pc-uninstalled
>
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
> configure | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
Mmh I think this will need some kind of README or doc/examples.txt for
common usages. ATM, as a developer I'm doing a:
./configure [...] --prefix=`pwd`/tmp-install && make -j20 && make install
And in the doc/examples directory:
PKG_CONFIG_PATH=$HOME/proj/ffmpeg/tmp-install/lib/pkgconfig make
I would expect users (in the future) to do a:
cp -r /usr/share/ffmpeg/examples ffmpeg-examples
cd ffmpeg-examples
make
Of course some users are picking the files from git and it would be nice
to have a friendly way of exploiting these examples, so your patch makes
sense to me.
Anyway, I support the idea, with some nit though: I'm not fond of
"pc-uninstalled" name, what about just "doc/examples/pkgconfig"?
Summary: the patch looks good to me if it works, assuming a simple
doc/examples/README describing the "developer" procedure and eventually a
rename of the pc-uninstalled directory.
[...]
--
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120513/d433f22b/attachment.asc>
More information about the ffmpeg-devel
mailing list