[FFmpeg-devel] superfluous log messages

[Michael Niedermayer]

On Thu, May 10, 2012 at 11:16:51PM -0400, Don Moir wrote:
> ----- Original Message ----- From: "Don Moir" <donmoir at comcast.net>
> To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
> Sent: Thursday, May 10, 2012 5:11 AM
> Subject: [FFmpeg-devel] superfluous log messages
> 
> 
> >>For some files, numerous log messages are output. These are
> >>sometimes useful during development but pretty much useless
> >>otherwise.
> >>
> >>I go ahead and set my own log callback via av_log_set_callback
> >>that does nothing so as to prevent further processing.
> >>
> >>Does anyone think it would be useful to call av_log_set_callback (NULL) ?
> >>
> >>av_log would just check for a NULL av_log_callback and do
> >>nothing if NULL.
> >>
> >>av_vlog would probably need to check for NULL as well.
> >>
> 
> >good idea, ill push a change along these lines in a moment
> 
> Probably would be good to put the test in av_log as well. This way
> the logic in av_log is turned off such as va_start etc and no
> additional function call. Mostly av_log is called which calls
> av_vlog.
> 
> No need to call av_vlog either from av_log and just call
> av_log_callback from av_log if it gets that far.

the callbak is non NULL for the overwhelming majority of users.

also av_log() should not be called in performance relevant code
and actually i dont think it is. think about it, if it was you would
get hundread thousand lines of text output per second at debug level
also such uses would need to be protected by a check before calling
av_log() not a check inside av_log()


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120511/edf23a98/attachment.asc>