[FFmpeg-devel] [PATCH]Accept j2k colourspaces with 1-7 and 9-15 bpp

[Michael Bradshaw]

Sorry, I'm not sure how I missed this one...

On Mon, May 7, 2012 at 4:19 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Hi!
>
> Only tested with the sample from ticket #1279 (that, iiuc, should be decoded
> incorrectly with the patch) and it looks like a conversion with jasper.

The patch looks good to me.

> Should I add the following in libopenjpeg_decode_frame()?
> avctx->bits_per_raw_sample = image->comps[0].prec;

Are there any potential issues with this if the chosen pix_fmt's bpp
is greater than bits_per_raw_sample? I don't know if you should set it
to comps[0].prec or sum the precision of the comps. The docs on
bits_per_raw_sample make it sound like it's the number of bits in a
single pixel (implies summing precision of comps) but ffv1.c certainly
doesn't use it like this. I trust you or someone else will know better
than me what to do with this.

Thanks,

Michael