[FFmpeg-devel] [PATCH 11/17] lavc/dcaenc: fix make checkheaders.

[Clément Bœsch]

On Wed, May 09, 2012 at 03:03:19PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > and i did often do a grep X *.{c,h} to quickly find where something is
> > defined, the renamings of .h->something else would complicate this.
> 
> +1
> 

git grep is your friend.

> (I cannot comment on the usefulness of make checkheaders, 
> I never used it.)
> 

As Michael suggested, conditionally adding os2threads.h to SKIPHEADERS
might be a solution. I'll look at this later.

About the usefulness, I think it's good to reduce the implicit header
dependencies, since it's not much effort and it's already done in most of
the code. I plan to add a FATE instance for this when everything is fixed.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120509/4d49a3e4/attachment.asc>