[FFmpeg-devel] [PATCHv3] lavf: add av_guess_frame_sample_aspect_ratio function

[Joakim Plate]

On Mon, May 7, 2012 at 11:03 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, May 07, 2012 at 08:39:32PM +0200, Joakim Plate wrote:
>> Just thought i'd chime in here. We (xbmc) ended up using that special
>> handling of stream aspect being 1:1 and codec aspect not being 1:1 to
>> solve a few samples we found in the wild. Thing the where mp4's
>> recorded by some camera if i remember correctly. So i'm sort of in
>> favor of that solution even if it's ugly.
>
> iam in favor of whatever works best and is simple
>
> in that sense, does anyone know how common in the wild files are that
> change the sample aspect ratio midstream but have a valid and not 1:1
> sample aspect at the format level ?
>

Can't really say.

Here our our ticket and change for this. Seems it was an MKV after all
so maybe i should just have asked him to re-mux the file.
https://github.com/xbmc/xbmc/commit/f08c8f01d1014a7f161d40a7cc8ede0680f9fe77
http://trac.xbmc.org/ticket/12187

And now that i look at it I notice the commit message is wrong. It's
the opposite order of what it does (what it does matches what was
proposed here).

/Joakim