[FFmpeg-devel] [PATCH] lavfi: Update AVFrame<->AVFillterBufferRef props copying.

Michael Niedermayer michaelni at gmx.at
Fri May 4 18:48:33 CEST 2012


On Fri, May 04, 2012 at 12:22:03PM +0200, Nicolas George wrote:
> Le sextidi 16 floréal, an CCXX, Robert Nagy a écrit :
> >  int avfilter_copy_frame_props(AVFilterBufferRef *dst, const AVFrame *src)
> >  {
> >      dst->pts    = src->pts;
> > -    dst->pos    = src->pkt_pos;
> > +    dst->pos    = av_frame_get_pkt_pos(src);
> >      dst->format = src->format;
> 
> Looks good.
[...]
> >      return 0;
> > @@ -63,10 +68,12 @@ int avfilter_fill_frame_from_audio_buffer_ref(AVFrame *frame,
> >          return AVERROR(EINVAL);
> >  
> >      memcpy(frame->data, samplesref->data, sizeof(frame->data));
> > -    frame->pkt_pos    = samplesref->pos;
> > +    av_frame_set_pkt_pos(frame->pkt_pos, samplesref->pos);
> >      frame->format     = samplesref->format;
> >      frame->nb_samples = samplesref->audio->nb_samples;
> >      frame->pts        = samplesref->pts;
> > +    av_frame_set_channel_layout(frame, samplesref->audio->channel_layout);
> > +    av_frame_set_sample_rate(frame, samplesref->audio->sample_rate);
> >  
> >      return 0;
> >  }
> > @@ -79,7 +86,7 @@ int avfilter_fill_frame_from_video_buffer_ref(AVFrame *frame,
> >  
> >      memcpy(frame->data,     picref->data,     sizeof(frame->data));
> >      memcpy(frame->linesize, picref->linesize, sizeof(frame->linesize));
> > -    frame->pkt_pos          = picref->pos;
> > +    av_frame_set_pkt_pos(frame->pkt_pos, picref->pos);
> >      frame->interlaced_frame = picref->video->interlaced;
> >      frame->top_field_first  = picref->video->top_field_first;
> >      frame->key_frame        = picref->video->key_frame;
> 
> Looks good, thanks.

LGTM too
robert do you have some public git clone from where i can merge
approved changes ?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120504/84fedb79/attachment.asc>


More information about the ffmpeg-devel mailing list