[FFmpeg-devel] lavfi: Add fps filter.

[Robert Nagy]

Here comes an update.

------------------------------------------------------------------


> Please post patches using 'git send-email', makes it easier to comment.


Unfortunately I'm behind a firewall that seems to block it.

Did you actually test it for both increase and resuction of FPS?


Yes.

 Please add into your patch also respective changes into makefiles, to
> make it compile from ffmpeg sources tree.


Can't build ffmpeg in my enviroment so I can't provide that. I don't
compile ffmpeg, just insert the filter with avfilter_register in my
application.

On Fri, May 4, 2012 at 12:53 PM, Andrey Utkin <
andrey.krieger.utkin at gmail.com> wrote:

> 2012/5/4 Robert Nagy <ronag89 at gmail.com>:
> > Good idea?
>
> Definitely yes.
> I have implemented such a filter for a company's non-distributable
> usage (not a trivial thing, and it's under NDA, thus sorry but can't
> disclose), it's quite handy to have.
>
>
> > auto fps = reinterpret_cast<FPSContext*>(link->src->priv);
>
> Definitely not a C expression. Please stick with C.
>
> Please add into your patch also respective changes into makefiles, to
> make it compile from ffmpeg sources tree.
> Did you actually test it for both increase and resuction of FPS?
> Did you test it for absense of memory leaks? This is probable issue as
> lavfi buffers are reference-counted.
> (I haven't dig into your algorithm.)
>
> --
> Andrey Utkin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-Add-fps-filter.patch
Type: application/octet-stream
Size: 3998 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120504/68c253d6/attachment.obj>