[FFmpeg-devel] Latest FFMPEG 0.9 Issues

[Baptiste Coudurier]

On 03/12/2012 07:44 AM, Michael Niedermayer wrote:
> On Sun, Mar 11, 2012 at 11:35:37PM -0700, Baptiste Coudurier wrote:
>> On 12/31/11 8:23 AM, Michael Niedermayer wrote:
>>> On Fri, Dec 30, 2011 at 09:52:21PM -0800, C Chatterjee wrote:
>>>> 
>>>> Michael:
>>>> 
>>>> Thanks for fixing the aacdec.c bug in item 1 below in an email sent by you earlier.
>>>> 
>>>> On item 2 I believe that checking as below: else if (enc->codec_id == CODEC_ID_AAC &&
>>>> pkt->size > 2 && (AV_RB16(pkt->data) & 0xfff0) == 0xfff0) { av_log(s, AV_LOG_ERROR,
>>>> "malformated aac bitstream, use -absf aac_adtstoasc\n"); return -1; may not be necessary
>>>> because the 2 byte header can be at the start of a payload too. I have used this stream
>>>> on a number of players - VLC, Flash and iPhone. All works. Is there a case of a player
>>>> where it does not work. I comment out the lines above in flvenc.c and movenc.c and use
>>>> ffmpeg as:
>>>> 
>>>> ffmpeg -y -i xx.flv -acodec copy -vcodec -preset superfast -b:v 150k ff.flv ff.flv works
>>>> fine on all players I have used.
>>> 
>>> hmm, maybe baptiste, mike or alex could comment on if this check is or is not required ?
>> 
>> The check is there to prevent muxing adts in flv, AFAIK flv requires raw aac.
> 
> do you know of some player that fails with adts or is there a spec that says what is allowed to
> be put in flv ?

Adobe specs
http://download.macromedia.com/f4v/video_file_format_spec_v10_1.pdf

[...]

-- 
Baptiste COUDURIER
Key fingerprint          8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                           http://www.ffmpeg.org