[FFmpeg-devel] [libav-devel] Enabling frame sizes changes with FF_THREAD_FRAMEs globally.

[Ronald S. Bultje]

Hi,

On Fri, Mar 9, 2012 at 2:52 PM, Dale Curtis <dalecurtis at chromium.org> wrote:
> Are there still any outstanding issues with enabling frame size changes with
> multiple threads globally? H264 and H263 have codec specific checks in
> place. Ronald suspects RV40 and MPEG codecs may have issues. Are there any
> others? Or other concerns to be aware of? I'm curious because, the Chromium
> team would like to enable this for VP8 frame size changes.
>
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index 23ab832..9f409fb 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -425,11 +425,6 @@ static int video_get_buffer(AVCodecContext *s, AVFrame
> *pic)
>      buf = &avci->buffer[avci->buffer_count];
>
>      if(buf->base[0] && (buf->width != w || buf->height != h || buf->pix_fmt
> != s->pix_fmt)){
> -        if(s->active_thread_type&FF_THREAD_FRAME) {
> -            av_log_missing_feature(s, "Width/height changing with frame
> threads is", 0);
> -            return -1;
> -        }
> -

Just to be clear, for VP8 I think this is well-tested, and for
intra-codecs I see no reason why it wouldn't work also. Main concern
is that I'd like tests to ensure we don't break it.

Ronald